-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New subtitle support #49
Conversation
Hello @ferishili, We used for the test scenarios Opencast Version 15.3 and Moodle Version 4.1.9+. |
@NinaHerrmann & @justusdieckmann, what do you think speaks against reviewing and releasing this PR? |
We do not have the capacity to review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ferishili,
thank you very much for the pull request!
If I understand correctly, in all cases where the strpos
is checked, the search-string should be at the start of the full string, right? So maybe strpos(...) === 0
would be better in those cases. Also, instead of str_replace('prefix', '', $tag)
, maybe you could use substr($tag, strlen('prefix'))
, because that will also work correctly in the (very unlikely) case, that 'prefix' is contained later in the string again.
Do you have any pointers to workflows or documentation regarding how to best setup the automatic captions to have an video to test with? I have found a talk about it, and the ts-api
repo, but no instructions how to integrate it in opencast.
Thank you!
Justus
minor improvements
Hi @justusdieckmann, Unfortunately, I have very little knowledge about automatic captions, but I would guess these docs could help! https://docs.opencast.org/r/15.x/admin/#configuration/transcription.configuration/whisper/ |
This PR fixes #48
Description
In Opencast 15, captions (subtitles) are provided with different format as for their flavors: captions/delivery ... etc. and every other data including language code etc. is included in the tags.
Solution
To TEST